feat(cli): --yes option to accept all questions
#826
Merged
+153
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ren-yamanashi
had a problem deploying
to
integ-approval
GitHub Actions
Failure
ren-yamanashi
changed the title
ren-yamanashi
had a problem deploying
to
integ-approval
GitHub Actions
Failure
ren-yamanashi
had a problem deploying
to
integ-approval
GitHub Actions
Failure
ren-yamanashi
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
+ Coverage 83.44% 84.49% +1.05%
==========================================
Files 71 71
Lines 10401 10437 +36
Branches 1314 1347 +33
==========================================
+ Hits 8679 8819 +140
+ Misses 1684 1577 -107
- Partials 38 41 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ren-yamanashi
had a problem deploying
to
integ-approval
GitHub Actions
Failure
ren-yamanashi
had a problem deploying
to
integ-approval
GitHub Actions
Failure
ren-yamanashi
had a problem deploying
to
integ-approval
GitHub Actions
Failure
ren-yamanashi
commented
Aug 30, 2025
Comment on lines
437
to
441
| // In non-interactive mode, always return success (true). | ||
| if (this.nonInteractive) { | ||
| return true; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Q. It should return msg.defaultResponse instead of true?
Contributor
There was a problem hiding this comment.
Yes, we need to return true for isConfirmationPrompt, msg.defaultResponse if there is one, and continue otherwise.
I would also like us to still print the question and answer and indicating that --yes was used.
We should also only do this after the this.skipApprovalStep(msg) check. On the other hand, --yes should make scenarios work where we don't have a TTY or are using concurrency. So we will need to restructure the checks.
ren-yamanashi
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
ren-yamanashi
had a problem deploying
to
run-tests
GitHub Actions
Failure
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
ren-yamanashi
temporarily deployed
to
run-tests
GitHub Actions
Inactive
mrgrain
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
--yescli option so that when provided, commands can continue without confirmation. Any confirmation prompts will be accepted. Other user input will use a default value if available. The CLI might still prompt for input in situations where there is no default answer.Fixes #732
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license